From 73d0600ad2bbbd724c910025259e7f8fdb9e4c33 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Tue, 30 Apr 2024 14:56:22 +0200 Subject: [PATCH] project: Set completion to undocumented if text empty (#11207) I think the previous code was missing a `return` in there because it always overwrote the `completion.documentation` field, even if the `text.is_empty()` is true. Release Notes: - N/A --- crates/project/src/project.rs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/crates/project/src/project.rs b/crates/project/src/project.rs index 29e8f7424b5e4b5104a03d8559c564d71717fae4..6f601e0ccee1b8024be2df0954529ae68fe73522 100644 --- a/crates/project/src/project.rs +++ b/crates/project/src/project.rs @@ -5723,13 +5723,9 @@ impl Project { return; }; - if response.text.is_empty() { - let mut completions = completions.write(); - let completion = &mut completions[completion_index]; - completion.documentation = Some(Documentation::Undocumented); - } - - let documentation = if response.is_markdown { + let documentation = if response.text.is_empty() { + Documentation::Undocumented + } else if response.is_markdown { Documentation::MultiLineMarkdown( markdown::parse_markdown(&response.text, &language_registry, None).await, )