From 750df6c93d08938a735be6b2b417778b4fb26f52 Mon Sep 17 00:00:00 2001 From: Kyle Kelley Date: Fri, 5 Jul 2024 12:37:01 -0700 Subject: [PATCH] Clean up comments in runtimes (#13870) --- crates/repl/src/outputs.rs | 6 +++--- crates/repl/src/session.rs | 1 - crates/zed/src/zed.rs | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/repl/src/outputs.rs b/crates/repl/src/outputs.rs index d502941667948592ae15f23db096d3d85e6fbd71..60b43f189f5405bb236533381f4f2da15160dfa4 100644 --- a/crates/repl/src/outputs.rs +++ b/crates/repl/src/outputs.rs @@ -365,13 +365,13 @@ impl ExecutionView { // Set next input adds text to the next cell. Not required to support. // However, this could be implemented by adding text to the buffer. - // runtimelib::Payload::SetNextInput { text, replace } => todo!(), + // runtimelib::Payload::SetNextInput { text, replace } => {}, // Not likely to be used in the context of Zed, where someone could just open the buffer themselves - // runtimelib::Payload::EditMagic { filename, line_number } => todo!(), + // runtimelib::Payload::EditMagic { filename, line_number } => {}, // Ask the user if they want to exit the kernel. Not required to support. - // runtimelib::Payload::AskExit { keepkernel } => todo!(), + // runtimelib::Payload::AskExit { keepkernel } => {}, _ => {} } } diff --git a/crates/repl/src/session.rs b/crates/repl/src/session.rs index 37e08df660067f34e3764da0c30939032184bfc0..89fd0c9d3399f21b792aed5e55020775579972b3 100644 --- a/crates/repl/src/session.rs +++ b/crates/repl/src/session.rs @@ -305,7 +305,6 @@ impl Session { fn shutdown(&mut self, cx: &mut ViewContext) { let kernel = std::mem::replace(&mut self.kernel, Kernel::ShuttingDown); - // todo!(): emit event for the runtime panel to remove this session once in shutdown state match kernel { Kernel::RunningKernel(mut kernel) => { diff --git a/crates/zed/src/zed.rs b/crates/zed/src/zed.rs index 8984fba4d3d1a861ad3bee09333814f1e0086f54..16a3c14107490794a80e2ba41fae6ea3e37fde79 100644 --- a/crates/zed/src/zed.rs +++ b/crates/zed/src/zed.rs @@ -198,7 +198,6 @@ pub fn initialize_workspace(app_state: Arc, cx: &mut AppContext) { let assistant_panel = assistant::AssistantPanel::load(workspace_handle.clone(), cx.clone()); - // todo!(): enable/disable this based on settings let runtime_panel = repl::RuntimePanel::load(workspace_handle.clone(), cx.clone()); let project_panel = ProjectPanel::load(workspace_handle.clone(), cx.clone());