From 7651854bbd892e2938673b8a5eed0d7f53278103 Mon Sep 17 00:00:00 2001 From: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Date: Tue, 25 Nov 2025 10:22:00 +0100 Subject: [PATCH] ci: Do not show output of failed tests at the end too (#43449) This reverts #39643, effectively For the record, @SomeoneToIgnore found it quite cumbersome to scroll through logs just to see which tests have failed. I kinda see the argument. At the same time, I wish nextest could do both: it could aggregate logs of failed tests and then print out the summary. Release Notes: - N/A --- .github/workflows/extension_tests.yml | 2 +- .github/workflows/release.yml | 6 +++--- .github/workflows/release_nightly.yml | 2 +- .github/workflows/run_tests.yml | 6 +++--- tooling/xtask/src/tasks/workflows/steps.rs | 5 +---- 5 files changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/workflows/extension_tests.yml b/.github/workflows/extension_tests.yml index 89289fbea20999ada413ef1801bb428f03c82c6b..e579c6739dd3201d37b8029fcbc205f28f9bafd9 100644 --- a/.github/workflows/extension_tests.yml +++ b/.github/workflows/extension_tests.yml @@ -77,7 +77,7 @@ jobs: uses: taiki-e/install-action@nextest - name: steps::cargo_nextest if: inputs.run_tests - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: bash -euxo pipefail {0} timeout-minutes: 3 check_extension: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 90d105880f94ee428f01746ed627f5c6f7d4e246..7afac285b5a34df2aadd04952400809059e12222 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -33,7 +33,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than 300 shell: bash -euxo pipefail {0} - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: bash -euxo pipefail {0} - name: steps::cleanup_cargo_config if: always() @@ -80,7 +80,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than 250 shell: bash -euxo pipefail {0} - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: bash -euxo pipefail {0} - name: steps::cleanup_cargo_config if: always() @@ -112,7 +112,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than.ps1 250 shell: pwsh - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: pwsh - name: steps::cleanup_cargo_config if: always() diff --git a/.github/workflows/release_nightly.yml b/.github/workflows/release_nightly.yml index bb327f2c5527d353c9aad01c3e26edcf5baac78c..d76244175accc3e816cbd7d5dc322d2529a0a236 100644 --- a/.github/workflows/release_nightly.yml +++ b/.github/workflows/release_nightly.yml @@ -51,7 +51,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than.ps1 250 shell: pwsh - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: pwsh - name: steps::cleanup_cargo_config if: always() diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml index 323dd7fd1b52eb43400658470ee7d7c986f219fa..8ed11788d44317d93899f629956567228fbb55fe 100644 --- a/.github/workflows/run_tests.yml +++ b/.github/workflows/run_tests.yml @@ -117,7 +117,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than.ps1 250 shell: pwsh - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: pwsh - name: steps::cleanup_cargo_config if: always() @@ -166,7 +166,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than 250 shell: bash -euxo pipefail {0} - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: bash -euxo pipefail {0} - name: steps::cleanup_cargo_config if: always() @@ -200,7 +200,7 @@ jobs: run: ./script/clear-target-dir-if-larger-than 300 shell: bash -euxo pipefail {0} - name: steps::cargo_nextest - run: cargo nextest run --workspace --no-fail-fast --failure-output immediate-final + run: cargo nextest run --workspace --no-fail-fast shell: bash -euxo pipefail {0} - name: steps::cleanup_cargo_config if: always() diff --git a/tooling/xtask/src/tasks/workflows/steps.rs b/tooling/xtask/src/tasks/workflows/steps.rs index c5edbdf8439675b4264388001322c12f4f3026e9..910b344cb7319e4f58911b3025632e560553716a 100644 --- a/tooling/xtask/src/tasks/workflows/steps.rs +++ b/tooling/xtask/src/tasks/workflows/steps.rs @@ -53,10 +53,7 @@ pub fn cargo_install_nextest() -> Step { } pub fn cargo_nextest(platform: Platform) -> Step { - named::run( - platform, - "cargo nextest run --workspace --no-fail-fast --failure-output immediate-final", - ) + named::run(platform, "cargo nextest run --workspace --no-fail-fast") } pub fn setup_cargo_config(platform: Platform) -> Step {