From 785fa3499d726fefe3111395e6f78768df6997ba Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Thu, 4 Dec 2025 03:00:59 -0500 Subject: [PATCH] hackity hack --- crates/editor/src/editor.rs | 6 ------ crates/editor/src/element.rs | 16 ++++++++-------- crates/editor/src/split.rs | 14 ++++++++++++-- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 114dbac23e80814c64471d7123ef73a29ccfc115..b1ebdfe4ac6e07b3dc7730c07a6ecd71d067a6f6 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -1204,7 +1204,6 @@ pub struct Editor { applicable_language_settings: HashMap, LanguageSettings>, accent_overrides: Vec, fetched_tree_sitter_chunks: HashMap>>, - use_base_text_line_numbers: bool, } fn debounce_value(debounce_ms: u64) -> Option { @@ -2351,7 +2350,6 @@ impl Editor { applicable_language_settings: HashMap::default(), accent_overrides: Vec::new(), fetched_tree_sitter_chunks: HashMap::default(), - use_base_text_line_numbers: false, }; if is_minimap { @@ -19277,10 +19275,6 @@ impl Editor { self.display_map.read(cx).fold_placeholder.clone() } - pub fn set_use_base_text_line_numbers(&mut self, show: bool, _cx: &mut Context) { - self.use_base_text_line_numbers = show; - } - pub fn set_expand_all_diff_hunks(&mut self, cx: &mut App) { self.buffer.update(cx, |buffer, cx| { buffer.set_all_diff_hunks_expanded(cx); diff --git a/crates/editor/src/element.rs b/crates/editor/src/element.rs index a4ddc086031050f49481b3e772667e1d071ce30c..97b436231b9f6777edfece8ab1d65d08804c9608 100644 --- a/crates/editor/src/element.rs +++ b/crates/editor/src/element.rs @@ -3278,14 +3278,14 @@ impl EditorElement { row_info.buffer_row? + 1 }; let relative_number = relative_rows.get(&display_row); - if !(relative_line_numbers_enabled && relative_number.is_some()) - && row_info - .diff_status - .is_some_and(|status| status.is_deleted()) - && !self.editor.read(cx).use_base_text_line_numbers - { - return None; - } + // FIXME + // if !(relative_line_numbers_enabled && relative_number.is_some()) + // && row_info + // .diff_status + // .is_some_and(|status| status.is_deleted()) + // { + // return None; + // } let number = relative_number.unwrap_or(&non_relative_number); write!(&mut line_number, "{number}").unwrap(); diff --git a/crates/editor/src/split.rs b/crates/editor/src/split.rs index b894d028f7899f081fa4aa6fc5532251295ee2e5..d527c54b4e68d553caca718ada6d8ba58e56a8cb 100644 --- a/crates/editor/src/split.rs +++ b/crates/editor/src/split.rs @@ -380,6 +380,11 @@ impl SecondaryEditor { }) .collect(); + let diff = primary_multibuffer + .diff_for(main_buffer.remote_id()) + .unwrap(); + let main_buffer = primary_multibuffer.buffer(main_buffer.remote_id()).unwrap(); + self.editor.update(cx, |editor, cx| { editor.buffer().update(cx, |buffer, cx| { buffer.update_path_excerpts( @@ -388,7 +393,13 @@ impl SecondaryEditor { &base_text_buffer_snapshot, new, cx, - ) + ); + buffer.add_inverted_diff( + base_text_buffer_snapshot.remote_id(), + diff, + main_buffer, + cx, + ); }) }); } @@ -432,6 +443,5 @@ mod tests { let editor = cx.new_window_entity(|window, cx| { SplittableEditor::new_unsplit(multibuffer, project, workspace, window, cx) }); - } }