collab_ui: Remove dependency on `vcs_menu` (#21016)

Marshall Bowers created 1 year ago

This PR removes the `vcs_menu` dependency from `collab_ui`.

We were only depending on this to call `vcs_menu::init`, which isn't
necessary to do here.

Release Notes:

- N/A

Change summary

Cargo.lock                        | 2 +-
crates/collab_ui/Cargo.toml       | 3 +--
crates/collab_ui/src/collab_ui.rs | 1 -
crates/zed/Cargo.toml             | 5 +++--
crates/zed/src/main.rs            | 1 +
5 files changed, 6 insertions(+), 6 deletions(-)

Detailed changes

Cargo.lock

@@ -2712,7 +2712,6 @@ dependencies = [
  "tree-sitter-md",
  "ui",
  "util",
- "vcs_menu",
  "workspace",
 ]
 
@@ -15574,6 +15573,7 @@ dependencies = [
  "urlencoding",
  "util",
  "uuid",
+ "vcs_menu",
  "vim",
  "welcome",
  "windows 0.58.0",

crates/collab_ui/Cargo.toml

@@ -58,12 +58,11 @@ settings.workspace = true
 smallvec.workspace = true
 story = { workspace = true, optional = true }
 theme.workspace = true
-time_format.workspace = true
 time.workspace = true
+time_format.workspace = true
 title_bar.workspace = true
 ui.workspace = true
 util.workspace = true
-vcs_menu.workspace = true
 workspace.workspace = true
 
 [dev-dependencies]

crates/collab_ui/src/collab_ui.rs

@@ -33,7 +33,6 @@ pub fn init(app_state: &Arc<AppState>, cx: &mut AppContext) {
     notification_panel::init(cx);
     notifications::init(app_state, cx);
     title_bar::init(cx);
-    vcs_menu::init(cx);
 }
 
 fn notification_window_options(

crates/zed/Cargo.toml

@@ -15,11 +15,11 @@ name = "zed"
 path = "src/main.rs"
 
 [dependencies]
-assistant_slash_command.workspace = true
 activity_indicator.workspace = true
 anyhow.workspace = true
 assets.workspace = true
 assistant.workspace = true
+assistant_slash_command.workspace = true
 async-watch.workspace = true
 audio.workspace = true
 auto_update.workspace = true
@@ -88,6 +88,7 @@ recent_projects.workspace = true
 release_channel.workspace = true
 remote.workspace = true
 repl.workspace = true
+reqwest_client.workspace = true
 rope.workspace = true
 search.workspace = true
 serde.workspace = true
@@ -112,11 +113,11 @@ theme_selector.workspace = true
 time.workspace = true
 toolchain_selector.workspace = true
 ui.workspace = true
-reqwest_client.workspace = true
 url.workspace = true
 urlencoding = "2.1.2"
 util.workspace = true
 uuid.workspace = true
+vcs_menu.workspace = true
 vim.workspace = true
 welcome.workspace = true
 workspace.workspace = true

crates/zed/src/main.rs

@@ -462,6 +462,7 @@ fn main() {
         call::init(app_state.client.clone(), app_state.user_store.clone(), cx);
         notifications::init(app_state.client.clone(), app_state.user_store.clone(), cx);
         collab_ui::init(&app_state, cx);
+        vcs_menu::init(cx);
         feedback::init(cx);
         markdown_preview::init(cx);
         welcome::init(cx);