Clean up code

Joseph T. Lyons created 2 years ago

Change summary

crates/call/src/call.rs        |  2 +-
crates/client/src/telemetry.rs |  2 +-
crates/welcome/src/welcome.rs  | 13 -------------
3 files changed, 2 insertions(+), 15 deletions(-)

Detailed changes

crates/call/src/call.rs

@@ -310,7 +310,7 @@ impl ActiveCall {
         })
     }
 
-    pub fn decline_incoming(&mut self, _cx: &mut ModelContext<Self>) -> Result<()> {
+    pub fn decline_incoming(&mut self, _: &mut ModelContext<Self>) -> Result<()> {
         let call = self
             .incoming_call
             .0

crates/client/src/telemetry.rs

@@ -213,7 +213,7 @@ impl Telemetry {
         drop(state);
 
         let this = self.clone();
-        cx.spawn(|_cx| async move {
+        cx.spawn(|_| async move {
             // Avoiding calling `System::new_all()`, as there have been crashes related to it
             let refresh_kind = RefreshKind::new()
                 .with_memory() // For memory usage

crates/welcome/src/welcome.rs

@@ -334,16 +334,3 @@ impl Item for WelcomePage {
         f(*event)
     }
 }
-
-// TODO
-//    - [X] get theme value
-//        - [X] In selector
-//        - [X] In main
-//    - [ ] get value of keymap selector
-//         - [X] In selector
-//         - [X] In main
-//    - [ ] get all button clicks
-//    - [ ] get value of usage data enabled
-//    - [ ] get value of crash reports enabled
-//    - [ ] get welcome screen close
-//    - [ ] test all events