From 80acfff622552130fe7ea5a9ab86307cfc2f6ee7 Mon Sep 17 00:00:00 2001
From: Finn Eitreim <48069764+feitreim@users.noreply.github.com>
Date: Fri, 13 Mar 2026 23:29:49 -0400
Subject: [PATCH] which-key: Removed some keys from the filter list that were
wrongly filtered (#51543)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Closes #49845
Follow up on #50992
Really simple, just removing some vim commands from the filter list that
are useful enough to justify not being filtered out.
tested to make sure the changes work:
Before you mark this PR as ready for review, make sure that you have:
- [x] Added a solid test coverage and/or screenshots from doing manual
testing
- [x] Done a self-review taking into account security and performance
aspects
- [x] Aligned any UI changes with the [UI
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
Release Notes:
- which-key: fixed filter list for some vim commands
---
crates/which_key/src/which_key.rs | 4 ----
1 file changed, 4 deletions(-)
diff --git a/crates/which_key/src/which_key.rs b/crates/which_key/src/which_key.rs
index 70889c100f33020a3ceaa8af1ba8812d5e7d4adb..d71bd646e70a4ede6047bd88416ea9314bddf12d 100644
--- a/crates/which_key/src/which_key.rs
+++ b/crates/which_key/src/which_key.rs
@@ -61,12 +61,8 @@ pub fn init(cx: &mut App) {
pub static FILTERED_KEYSTROKES: LazyLock>> = LazyLock::new(|| {
[
// Modifiers on normal vim commands
- "g h",
"g j",
"g k",
- "g l",
- "g $",
- "g ^",
// Duplicate keys with "ctrl" held, e.g. "ctrl-w ctrl-a" is duplicate of "ctrl-w a"
"ctrl-w ctrl-a",
"ctrl-w ctrl-c",