From 81733d41db020488120ce51548631bb4db0748f2 Mon Sep 17 00:00:00 2001 From: daydalek <90121301+daydalek@users.noreply.github.com> Date: Wed, 8 Apr 2026 14:52:37 +0800 Subject: [PATCH] settings_ui: Fix hover popover delay setting's json_path (#53359) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "Hover Popover → Delay" setting item had its json_path set to "hover_popover_enabled" (copy-paste error from the item above it), introduced in #40739. This caused: - "Copy Link" generating a wrong zed://settings/hover_popover_enabled URL - #hover_popover_delay filter returning no results in settings search - Telemetry reporting delay changes as hover_popover_enabled The pick/write closures were always correct, so the setting itself functioned normally. after the fix, filter works correctly image and the copy link button return the correct result image Release Notes: - N/A Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- crates/settings_ui/src/page_data.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/settings_ui/src/page_data.rs b/crates/settings_ui/src/page_data.rs index 07e462da9ca2a5c7f7cc766aa6616e956b2f3aea..ac8636c985b0e3427f6048b5f3133a995a186298 100644 --- a/crates/settings_ui/src/page_data.rs +++ b/crates/settings_ui/src/page_data.rs @@ -1757,7 +1757,7 @@ fn editor_page() -> SettingsPage { title: "Delay", description: "Time to wait in milliseconds before showing the informational hover box.", field: Box::new(SettingField { - json_path: Some("hover_popover_enabled"), + json_path: Some("hover_popover_delay"), pick: |settings_content| settings_content.editor.hover_popover_delay.as_ref(), write: |settings_content, value| { settings_content.editor.hover_popover_delay = value;