From 83498ebf2b867170f5a7cc6cd474cd48ba828daf Mon Sep 17 00:00:00 2001 From: Ben Kunkle Date: Wed, 14 May 2025 12:22:17 -0500 Subject: [PATCH] Improve error message around failing to install dev extensions (#30711) Closes #ISSUE Release Notes: - N/A *or* Added/Fixed/Improved ... --- Cargo.lock | 1 + crates/extensions_ui/Cargo.toml | 3 ++- crates/extensions_ui/src/extensions_ui.rs | 5 ++++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 511f389955fede0027d998622a2ef363387c4833..0b8299c94e33dd9bd29af984bde75eefa02f961a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5161,6 +5161,7 @@ dependencies = [ "fuzzy", "gpui", "language", + "log", "num-format", "picker", "project", diff --git a/crates/extensions_ui/Cargo.toml b/crates/extensions_ui/Cargo.toml index bc68c98ebc10961c51e06ab01012b1165e484c38..c31483d763d963edbd0e64d5dc26a4aaf2ed6aeb 100644 --- a/crates/extensions_ui/Cargo.toml +++ b/crates/extensions_ui/Cargo.toml @@ -23,6 +23,7 @@ fs.workspace = true fuzzy.workspace = true gpui.workspace = true language.workspace = true +log.workspace = true num-format.workspace = true picker.workspace = true project.workspace = true @@ -37,9 +38,9 @@ theme.workspace = true ui.workspace = true util.workspace = true vim_mode_setting.workspace = true +workspace-hack.workspace = true workspace.workspace = true zed_actions.workspace = true -workspace-hack.workspace = true [dev-dependencies] editor = { workspace = true, features = ["test-support"] } diff --git a/crates/extensions_ui/src/extensions_ui.rs b/crates/extensions_ui/src/extensions_ui.rs index 03836873047c7417c8486823c5ea7b2ece3bdc33..792d3087641e8f16c64158ff454d273e849fb1a6 100644 --- a/crates/extensions_ui/src/extensions_ui.rs +++ b/crates/extensions_ui/src/extensions_ui.rs @@ -132,10 +132,13 @@ pub fn init(cx: &mut App) { match install_task.await { Ok(_) => {} Err(err) => { + log::error!("Failed to install dev extension: {:?}", err); workspace_handle .update(cx, |workspace, cx| { workspace.show_error( - &err.context("failed to install dev extension"), + // NOTE: using `anyhow::context` here ends up not printing + // the error + &format!("Failed to install dev extension: {}", err), cx, ); })