Drop active searchable item subscription when changing active item (#4220)

Antonio Scandurra created 2 years ago

We were leaking the previous active item's subscription, which meant
that we would receive the `MatchesInvalidated` event as many times as we
changed items.

Release Notes:

- Fixed a performance issue when switching the active item while the
search bar was open.

Change summary

crates/search/src/buffer_search.rs | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

Detailed changes

crates/search/src/buffer_search.rs

@@ -396,8 +396,8 @@ impl ToolbarItemView for BufferSearchBar {
         {
             let this = cx.view().downgrade();
 
-            searchable_item_handle
-                .subscribe_to_search_events(
+            self.active_searchable_item_subscription =
+                Some(searchable_item_handle.subscribe_to_search_events(
                     cx,
                     Box::new(move |search_event, cx| {
                         if let Some(this) = this.upgrade() {
@@ -406,8 +406,7 @@ impl ToolbarItemView for BufferSearchBar {
                             });
                         }
                     }),
-                )
-                .detach();
+                ));
 
             self.active_searchable_item = Some(searchable_item_handle);
             let _ = self.update_matches(cx);