Respect lsp completions' 'insert_text' property when present

Max Brunsfeld created 3 years ago

Fixes #839

Change summary

crates/project/src/project.rs | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

Detailed changes

crates/project/src/project.rs

@@ -2502,13 +2502,12 @@ impl Project {
                                         log::info!("completion out of expected range");
                                         return None;
                                     }
-                                    (
-                                        this.common_prefix_at(
-                                            clipped_position,
-                                            &lsp_completion.label,
-                                        ),
-                                        lsp_completion.label.clone(),
-                                    )
+                                    let text = lsp_completion
+                                        .insert_text
+                                        .as_ref()
+                                        .unwrap_or(&lsp_completion.label)
+                                        .clone();
+                                    (this.common_prefix_at(clipped_position, &text), text.clone())
                                 }
                                 Some(lsp::CompletionTextEdit::InsertAndReplace(_)) => {
                                     log::info!("unsupported insert/replace completion");