From 8f7d7863d66718e51fc7255aa76239af0bc3a7f4 Mon Sep 17 00:00:00 2001 From: Robert Clover Date: Fri, 9 Feb 2024 04:12:45 +1100 Subject: [PATCH] Fix text in terminal showing as bold when dimmed (#7491) Fixes text in the terminal displaying as bold when it's actually just dim. I think it was just a simple oversight because the original code `|`'s together the BOLD and DIM_BOLD flags, which is the same as DIM_BOLD, which is wrong because it should only be BOLD :p Release Notes: - Fixed #4464 Co-authored-by: Mikayla Maki --- crates/terminal_view/src/terminal_element.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/terminal_view/src/terminal_element.rs b/crates/terminal_view/src/terminal_element.rs index addf55ee45e1e8850f52562c5638e52181504402..2696a6058c07f0bc513d91438f5073483001cb83 100644 --- a/crates/terminal_view/src/terminal_element.rs +++ b/crates/terminal_view/src/terminal_element.rs @@ -347,7 +347,7 @@ impl TerminalElement { thickness: Pixels::from(1.0), }); - let weight = if flags.intersects(Flags::BOLD | Flags::DIM_BOLD) { + let weight = if flags.intersects(Flags::BOLD) { FontWeight::BOLD } else { FontWeight::NORMAL