Tweak LSP log menu styling

Max Brunsfeld created 2 years ago

Change summary

crates/lsp_log/src/lsp_log.rs      | 15 +++++++++------
crates/theme/src/theme.rs          |  1 +
styles/src/styleTree/lspLogMenu.ts |  1 +
3 files changed, 11 insertions(+), 6 deletions(-)

Detailed changes

crates/lsp_log/src/lsp_log.rs

@@ -659,16 +659,17 @@ impl LspLogToolbarItemView {
                 )
                 .contained()
                 .with_style(style.container)
-                .aligned()
-                .left()
+                .constrained()
+                .with_height(theme.lsp_log_menu.row_height)
             })
             .with_child(
                 MouseEventHandler::<ActivateLog, _>::new(id.0, cx, move |state, _| {
                     let style = theme.lsp_log_menu.item.style_for(state, logs_selected);
-                    Flex::row()
-                        .with_child(Label::new(SERVER_LOGS, style.text.clone()).aligned().left())
+                    Label::new(SERVER_LOGS, style.text.clone())
                         .contained()
                         .with_style(style.container)
+                        .constrained()
+                        .with_height(theme.lsp_log_menu.row_height)
                 })
                 .with_cursor_style(CursorStyle::PointingHand)
                 .on_click(MouseButton::Left, move |_, view, cx| {
@@ -681,8 +682,8 @@ impl LspLogToolbarItemView {
                     Flex::row()
                         .with_child(
                             Label::new(RPC_MESSAGES, style.text.clone())
-                                .aligned()
-                                .left(),
+                                .constrained()
+                                .with_height(theme.lsp_log_menu.row_height),
                         )
                         .with_child(
                             ui::checkbox_with_label::<Self, _, Self, _>(
@@ -700,6 +701,8 @@ impl LspLogToolbarItemView {
                         .align_children_center()
                         .contained()
                         .with_style(style.container)
+                        .constrained()
+                        .with_height(theme.lsp_log_menu.row_height)
                 })
                 .with_cursor_style(CursorStyle::PointingHand)
                 .on_click(MouseButton::Left, move |_, view, cx| {

crates/theme/src/theme.rs

@@ -252,6 +252,7 @@ pub struct LspLogMenu {
     pub header: Interactive<ContainedText>,
     pub server: ContainedText,
     pub item: Interactive<ContainedText>,
+    pub row_height: f32,
 }
 
 #[derive(Clone, Deserialize, Default)]

styles/src/styleTree/lspLogMenu.ts

@@ -5,6 +5,7 @@ export default function contactsPanel(colorScheme: ColorScheme) {
     let layer = colorScheme.middle
 
     return {
+        rowHeight: 30,
         background: background(layer),
         border: border(layer),
         shadow: colorScheme.popoverShadow,