Fix `clippy::map_clone` lint violations (#36585)

tidely created 3 months ago

#36577

Release Notes:

- N/A

Change summary

Cargo.toml                                   | 1 +
crates/git_ui/src/git_panel.rs               | 2 +-
crates/gpui/src/platform/linux/x11/client.rs | 2 +-
crates/workspace/src/pane.rs                 | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)

Detailed changes

Cargo.toml

@@ -879,6 +879,7 @@ manual_pattern_char_comparison = "warn"
 manual_rotate = "warn"
 manual_slice_fill = "warn"
 manual_while_let_some = "warn"
+map_clone = "warn"
 map_collect_result_unit = "warn"
 match_like_matches_macro = "warn"
 match_overlapping_arm = "warn"

crates/git_ui/src/git_panel.rs

@@ -1335,7 +1335,7 @@ impl GitPanel {
                         section.contains(status_entry, repository)
                             && status_entry.staging.as_bool() != Some(goal_staged_state)
                     })
-                    .map(|status_entry| status_entry.clone())
+                    .cloned()
                     .collect::<Vec<_>>();
 
                 (goal_staged_state, entries)

crates/gpui/src/platform/linux/x11/client.rs

@@ -2108,7 +2108,7 @@ fn current_pointer_device_states(
                     .classes
                     .iter()
                     .filter_map(|class| class.data.as_scroll())
-                    .map(|class| *class)
+                    .copied()
                     .rev()
                     .collect::<Vec<_>>();
                 let old_state = scroll_values_to_preserve.get(&info.deviceid);

crates/workspace/src/pane.rs

@@ -3082,7 +3082,7 @@ impl Pane {
                             .read(cx)
                             .items()
                             .find(|item| item.item_id() == item_id)
-                            .map(|item| item.clone())
+                            .cloned()
                         else {
                             return;
                         };