Fix bug when determining contact status

Antonio Scandurra and Nathan Sobo created

Users are sorted by login but we were binary-searching them by id.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Change summary

crates/client/src/user.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Detailed changes

crates/client/src/user.rs 🔗

@@ -283,19 +283,19 @@ impl UserStore {
             ContactRequestStatus::Pending
         } else if self
             .contacts
-            .binary_search_by_key(&&user.id, |contact| &contact.user.id)
+            .binary_search_by_key(&&user.github_login, |contact| &contact.user.github_login)
             .is_ok()
         {
             ContactRequestStatus::RequestAccepted
         } else if self
             .outgoing_contact_requests
-            .binary_search_by_key(&&user.id, |user| &user.id)
+            .binary_search_by_key(&&user.github_login, |user| &user.github_login)
             .is_ok()
         {
             ContactRequestStatus::RequestSent
         } else if self
             .incoming_contact_requests
-            .binary_search_by_key(&&user.id, |user| &user.id)
+            .binary_search_by_key(&&user.github_login, |user| &user.github_login)
             .is_ok()
         {
             ContactRequestStatus::RequestReceived