From 94faaebfec5e46afa6d3aee5372cbbdb33b97c33 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Sat, 3 Jan 2026 00:21:11 +0200 Subject: [PATCH] Clean up image resources for the current window (#45969) Closes https://github.com/zed-industries/zed/issues/35894 Trace: https://drive.google.com/file/d/1pXDFzOg4ZS4p2SX8fk9Cjnyy1Qd1Pkrx/view?usp=sharing [Relevant part](https://github.com/user-attachments/files/24412472/image_leak.txt) Release Notes: - Fixed a memory leak when opening images --- crates/image_viewer/src/image_viewer.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/image_viewer/src/image_viewer.rs b/crates/image_viewer/src/image_viewer.rs index 4474b2a9bf7d8d4fe117575d9323e7fee8df1eb2..f268588b58ccd07c1ecc367aeaaaf80c4f0996cf 100644 --- a/crates/image_viewer/src/image_viewer.rs +++ b/crates/image_viewer/src/image_viewer.rs @@ -44,7 +44,7 @@ impl ImageView { cx.on_release_in(window, |this, window, cx| { let image_data = this.image_item.read(cx).image.clone(); if let Some(image) = image_data.clone().get_render_image(window, cx) { - cx.drop_image(image, None); + cx.drop_image(image, Some(window)); } image_data.remove_asset(cx); })