Don't dismiss inline assistant when an error occurs (#2971)

Antonio Scandurra created 2 years ago

Release Notes:

- Fixed a bug that was preventing errors from being shown in the inline
assistant when it was still deployed. (preview-only)

Change summary

crates/ai/src/assistant.rs | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Detailed changes

crates/ai/src/assistant.rs

@@ -386,10 +386,12 @@ impl AssistantPanel {
                                             );
                                         })
                                     }
+
+                                    this.finish_inline_assist(inline_assist_id, false, cx);
                                 }
+                            } else {
+                                this.finish_inline_assist(inline_assist_id, false, cx);
                             }
-
-                            this.finish_inline_assist(inline_assist_id, false, cx);
                         }
                     }),
                 ],
@@ -2837,6 +2839,7 @@ impl InlineAssistant {
                         cx,
                     );
                 } else {
+                    self.confirmed = false;
                     editor.set_read_only(false);
                     editor.set_field_editor_style(
                         Some(Arc::new(|theme| theme.assistant.inline.editor.clone())),