Fix delay in Copilot completion (#46885) (cherry-pick to preview) (#46895)

zed-zippy[bot] and Hieu Pham created 1 week ago

Cherry-pick of #46885 to preview

----
This PR fixes an issue when copilot takes 3s to complete. Right now, in
copilot edit prediction, we issue requests to both the Next Edit
Suggestion (NES) and the regular copilot inline completion endpoints.
Whichever come back first will be shown. However, there is a bug where
even if inline completion (which is usually much faster) comes back, we
still wait for NES (which takes about 3s).

This should address https://github.com/zed-industries/zed/issues/46389
and https://github.com/zed-industries/zed/issues/46880

Release notes:
- Improved responsiveness of Copilot inline completions.

Co-authored-by: Hieu Pham <[e-mail]>

Change summary

crates/copilot/src/copilot.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Detailed changes

crates/copilot/src/copilot.rs

@@ -1021,7 +1021,7 @@ impl Copilot {
                     }
                     inline = inline_request => {
                         let completions = inline.into_response().ok().map(convert_inline).unwrap_or_default();
-                        if !completions.is_empty() && nes_result.is_some() {
+                        if !completions.is_empty() {
                             return Ok(completions);
                         }
                         inline_result = Some(completions);