Rebased to main

Mikayla Maki created 3 years ago

Change summary

crates/collab/src/integration_tests.rs    | 4 ++--
crates/collab/src/main.rs                 | 2 +-
crates/editor/src/items.rs                | 4 ++--
crates/editor/src/persistence.rs          | 2 +-
crates/sqlez/src/migrations.rs            | 2 +-
crates/terminal/src/terminal.rs           | 2 --
crates/workspace/src/persistence/model.rs | 4 +---
crates/workspace/src/workspace.rs         | 4 ++--
8 files changed, 10 insertions(+), 14 deletions(-)

Detailed changes

crates/collab/src/integration_tests.rs

@@ -1,6 +1,6 @@
 use crate::{
-    db::{NewUserParams, ProjectId, TestDb, UserId},
-    rpc::{Executor, Server, Store},
+    db::{NewUserParams, ProjectId, SqliteTestDb as TestDb, UserId},
+    rpc::{Executor, Server},
     AppState,
 };
 

crates/collab/src/main.rs

@@ -9,11 +9,11 @@ mod db_tests;
 #[cfg(test)]
 mod integration_tests;
 
-use crate::db::{Db, PostgresDb};
 use crate::rpc::ResultExt as _;
 use anyhow::anyhow;
 use axum::{routing::get, Router};
 use collab::{Error, Result};
+use db::DefaultDb as Db;
 use serde::Deserialize;
 use std::{
     env::args,

crates/editor/src/items.rs

@@ -1,7 +1,7 @@
 use crate::{
     display_map::ToDisplayPoint, link_go_to_definition::hide_link_definition,
-    movement::surrounding_word, Anchor, Autoscroll, Editor, EditorMode, Event, ExcerptId,
-    MultiBuffer, MultiBufferSnapshot, NavigationData, ToPoint as _, FORMAT_TIMEOUT,
+    movement::surrounding_word, Anchor, Autoscroll, Editor, Event, ExcerptId, MultiBuffer,
+    MultiBufferSnapshot, NavigationData, ToPoint as _, FORMAT_TIMEOUT,
 };
 use anyhow::{anyhow, Context, Result};
 use futures::FutureExt;

crates/editor/src/persistence.rs

@@ -24,7 +24,7 @@ impl Domain for Editor {
 }
 
 impl EditorDb {
-    fn get_path(_item_id: ItemId, _workspace_id: WorktreeId) -> PathBuf {
+    fn _get_path(_item_id: ItemId, _workspace_id: WorktreeId) -> PathBuf {
         unimplemented!();
     }
 }

crates/sqlez/src/migrations.rs

@@ -58,7 +58,7 @@ impl Connection {
 mod test {
     use indoc::indoc;
 
-    use crate::{connection::Connection, thread_safe_connection::ThreadSafeConnection};
+    use crate::connection::Connection;
 
     #[test]
     fn test_migrations_are_added_to_table() {

crates/terminal/src/terminal.rs

@@ -34,9 +34,7 @@ use mappings::mouse::{
 
 use procinfo::LocalProcessInfo;
 use settings::{AlternateScroll, Settings, Shell, TerminalBlink};
-use terminal_container_view::TerminalContainer;
 use util::ResultExt;
-use workspace::register_deserializable_item;
 
 use std::{
     cmp::min,

crates/workspace/src/persistence/model.rs

@@ -16,9 +16,7 @@ use sqlez::{
 };
 use util::ResultExt;
 
-use crate::{
-    dock::DockPosition, item::ItemHandle, ItemDeserializers, Member, Pane, PaneAxis, Workspace,
-};
+use crate::{dock::DockPosition, ItemDeserializers, Member, Pane, PaneAxis, Workspace};
 
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct WorkspaceId(Arc<Vec<PathBuf>>);

crates/workspace/src/workspace.rs

@@ -677,7 +677,7 @@ impl Workspace {
         cx: &mut MutableAppContext,
     ) -> Task<(
         ViewHandle<Workspace>,
-        Vec<Option<Result<Box<dyn ItemHandle>, Arc<anyhow::Error>>>>,
+        Vec<Option<Result<Box<dyn ItemHandle>, anyhow::Error>>>,
     )> {
         let project_handle = Project::local(
             app_state.client.clone(),
@@ -740,7 +740,7 @@ impl Workspace {
                                 Some(
                                     workspace
                                         .update(&mut cx, |workspace, cx| {
-                                            workspace.open_path(project_path, true, cx)
+                                            workspace.open_path(project_path, None, true, cx)
                                         })
                                         .await,
                                 )