From 9a9e96ed5a4d3a31cf075a31c3df3186c19496c5 Mon Sep 17 00:00:00 2001 From: Alisina Bahadori Date: Mon, 2 Jun 2025 09:55:40 -0400 Subject: [PATCH] Increase terminal inline assistant block height (#31807) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #31806 Closes #28969 Not sure if a static value is best. Maybe it is better to somehow use `count_lines` function here too. ### Before 449463234-ab1a33a0-2331-4605-aaee-cae60ddd0f9d ### After Screenshot 2025-05-31 at 1 12 33 AM Release Notes: - Fixed terminal inline assistant clipping when cursor is at bottom of terminal. --- crates/agent/src/terminal_inline_assistant.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/agent/src/terminal_inline_assistant.rs b/crates/agent/src/terminal_inline_assistant.rs index 8f04904b3abaf16851a71d5973845692163f95b3..d96e37ea58bab0bcad8d594b3602050b9a5922bf 100644 --- a/crates/agent/src/terminal_inline_assistant.rs +++ b/crates/agent/src/terminal_inline_assistant.rs @@ -106,7 +106,7 @@ impl TerminalInlineAssistant { }); let prompt_editor_render = prompt_editor.clone(); let block = terminal_view::BlockProperties { - height: 2, + height: 4, render: Box::new(move |_| prompt_editor_render.clone().into_any_element()), }; terminal_view.update(cx, |terminal_view, cx| {