From 9bc4e3b4ae4c248ef0342529caa23bef4593e19b Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Thu, 10 Oct 2024 16:10:18 +0300 Subject: [PATCH] Do not resolve more completion fields (#19021) As Zed instantly shows completion items in the completion menu, and the resolve will cause the details to appear, flickering. We can safely resolve the `documentation`, `additionalTextEdits` and `command` fields, the rest should be resolved eagerly for now. Release Notes: - Fixed completion menu rendering --- crates/lsp/src/lsp.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/crates/lsp/src/lsp.rs b/crates/lsp/src/lsp.rs index 8d67855e39019be0808e0b60a15d56c76c9e4d26..a105c983f9ec362926b33f019218b984e398d669 100644 --- a/crates/lsp/src/lsp.rs +++ b/crates/lsp/src/lsp.rs @@ -626,11 +626,7 @@ impl LanguageServer { properties: vec![ "additionalTextEdits".to_string(), "command".to_string(), - "detail".to_string(), "documentation".to_string(), - "filterText".to_string(), - "labelDetails".to_string(), - "tags".to_string(), // NB: Do not have this resolved, otherwise Zed becomes slow to complete things // "textEdit".to_string(), ],