Enable `clippy::cmp_owned` (#8899)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::cmp_owned`](https://rust-lang.github.io/rust-clippy/master/index.html#/cmp_owned)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

Cargo.toml                              | 1 -
crates/assistant/src/assistant_panel.rs | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)

Detailed changes

Cargo.toml

@@ -373,7 +373,6 @@ arc_with_non_send_sync = "allow"
 await_holding_lock = "allow"
 borrowed_box = "allow"
 cast_abs_to_unsigned = "allow"
-cmp_owned = "allow"
 derive_ord_xor_partial_ord = "allow"
 eq_op = "allow"
 implied_bounds_in_impls = "allow"

crates/assistant/src/assistant_panel.rs

@@ -652,7 +652,7 @@ impl AssistantPanel {
         // If Markdown or No Language is Known, increase the randomness for more creative output
         // If Code, decrease temperature to get more deterministic outputs
         let temperature = if let Some(language) = language_name.clone() {
-            if language.to_string() != "Markdown".to_string() {
+            if *language != *"Markdown" {
                 0.5
             } else {
                 1.0