From 9ebd5863505dbdd85cc37e7728a01f69461acb2d Mon Sep 17 00:00:00 2001
From: Antonio Scandurra <me@as-cii.com>
Date: Thu, 13 Oct 2022 16:40:52 +0200
Subject: [PATCH] Improve error message when rendering a child view for a
 dropped view

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
---
 crates/gpui/src/presenter.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/gpui/src/presenter.rs b/crates/gpui/src/presenter.rs
index 1d59905d7cc8a542505d0fcb3c19a94cca963e0b..4eef9c73985ae093ea1b57f76692881bf0a0fb21 100644
--- a/crates/gpui/src/presenter.rs
+++ b/crates/gpui/src/presenter.rs
@@ -1001,7 +1001,7 @@ impl Element for ChildView {
             (size, true)
         } else {
             log::error!(
-                "layout called on a view (id: {}, name: {:?}) that was not rendered",
+                "layout called on a ChildView element whose underlying view was dropped (view_id: {}, name: {:?})",
                 self.view.id(),
                 self.view_name
             );
@@ -1020,7 +1020,7 @@ impl Element for ChildView {
             cx.paint(self.view.id(), bounds.origin(), visible_bounds);
         } else {
             log::error!(
-                "paint called on a view (id: {}, name: {:?}) that was not rendered",
+                "paint called on a ChildView element whose underlying view was dropped (view_id: {}, name: {:?})",
                 self.view.id(),
                 self.view_name
             );
@@ -1040,7 +1040,7 @@ impl Element for ChildView {
             cx.dispatch_event(self.view.id(), event)
         } else {
             log::error!(
-                "dispatch_event called on a view (id: {}, name: {:?}) that was not rendered",
+                "dispatch_event called on a ChildView element whose underlying view was dropped (view_id: {}, name: {:?})",
                 self.view.id(),
                 self.view_name
             );
@@ -1061,7 +1061,7 @@ impl Element for ChildView {
             cx.rect_for_text_range(self.view.id(), range_utf16)
         } else {
             log::error!(
-                "rect_for_text_range called on a view (id: {}, name: {:?}) that was not rendered",
+                "rect_for_text_range called on a ChildView element whose underlying view was dropped (view_id: {}, name: {:?})",
                 self.view.id(),
                 self.view_name
             );