Assign draw order to surfaces using plane splitter (#3739)

Max Brunsfeld created 2 years ago

It looks like we neglected to incorporate surfaces into the
plane-splitting code path, which assigns each graphics primitive's draw
order.

This fixes an issue where screensharing frames were not visible when the
screenshare tab was zoomed.

Change summary

crates/gpui2/src/scene.rs | 9 +++++++++
1 file changed, 9 insertions(+)

Detailed changes

crates/gpui2/src/scene.rs

@@ -104,6 +104,15 @@ impl SceneBuilder {
             );
         }
 
+        for (ix, surface) in self.surfaces.iter().enumerate() {
+            let z = layer_z_values[surface.order as LayerId as usize];
+            self.splitter.add(
+                surface
+                    .bounds
+                    .to_bsp_polygon(z, (PrimitiveKind::Surface, ix)),
+            );
+        }
+
         // Sort all polygons, then reassign the order field of each primitive to `draw_order`
         // We need primitives to be repr(C), hence the weird reuse of the order field for two different types.
         for (draw_order, polygon) in self