Remove unused `{cancel,finish}_composition` methods

Antonio Scandurra created 3 years ago

Change summary

crates/gpui/src/app.rs                 | 12 ------------
crates/gpui/src/platform.rs            |  2 --
crates/gpui/src/platform/mac/window.rs |  2 +-
3 files changed, 1 insertion(+), 15 deletions(-)

Detailed changes

crates/gpui/src/app.rs

@@ -445,18 +445,6 @@ impl InputHandler for WindowInputHandler {
             );
         });
     }
-
-    // TODO - do these need to be handled separately?
-
-    fn cancel_composition(&mut self) {
-        println!("cancel_composition()");
-        self.unmark_text();
-    }
-
-    fn finish_composition(&mut self) {
-        println!("finish_composition()");
-        self.unmark_text();
-    }
 }
 
 #[cfg(any(test, feature = "test-support"))]

crates/gpui/src/platform.rs

@@ -102,8 +102,6 @@ pub trait InputHandler {
     );
     fn marked_text_range(&self) -> Option<Range<usize>>;
     fn unmark_text(&mut self);
-    fn cancel_composition(&mut self);
-    fn finish_composition(&mut self);
 }
 
 pub trait Window: WindowContext {

crates/gpui/src/platform/mac/window.rs

@@ -1097,7 +1097,7 @@ extern "C" fn set_marked_text(
 }
 
 extern "C" fn unmark_text(this: &Object, _: Sel) {
-    with_input_handler(this, |input_handler| input_handler.finish_composition());
+    with_input_handler(this, |input_handler| input_handler.unmark_text());
 }
 
 extern "C" fn attributed_substring_for_proposed_range(