From a66dac7b3a065014e9729e25ea5ac4322014b037 Mon Sep 17 00:00:00 2001 From: John Tur Date: Fri, 7 Nov 2025 14:18:47 -0500 Subject: [PATCH] Fix crash during drag-and-drop on Windows (#42227) The HGLOBAL is itself the HDROP. Do not dereference it. Release Notes: - windows: Fixed crashes during drag-and-drop operations --- crates/gpui/src/platform/windows/window.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/gpui/src/platform/windows/window.rs b/crates/gpui/src/platform/windows/window.rs index e7ef395df232637d7acbbac8618a3b46b8182fdc..a9217a85e3e38697fbb06aea3067901d222e3986 100644 --- a/crates/gpui/src/platform/windows/window.rs +++ b/crates/gpui/src/platform/windows/window.rs @@ -901,9 +901,9 @@ impl IDropTarget_Impl for WindowsDragDropHandler_Impl { if idata.u.hGlobal.is_invalid() { return Ok(()); } - let hdrop = idata.u.hGlobal.0 as *mut HDROP; + let hdrop = HDROP(idata.u.hGlobal.0); let mut paths = SmallVec::<[PathBuf; 2]>::new(); - with_file_names(*hdrop, |file_name| { + with_file_names(hdrop, |file_name| { if let Some(path) = PathBuf::from_str(&file_name).log_err() { paths.push(path); }