Toggle comments for empty single line selections

Kevin Hovsäter created 2 years ago

Change summary

crates/editor/src/editor.rs       |  2 
crates/editor/src/editor_tests.rs | 51 +++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+), 1 deletion(-)

Detailed changes

crates/editor/src/editor.rs

@@ -5480,7 +5480,7 @@ impl Editor {
                     let mut all_selection_lines_are_comments = true;
 
                     for row in start_row..=end_row {
-                        if snapshot.is_line_blank(row) {
+                        if snapshot.is_line_blank(row) && start_row < end_row {
                             continue;
                         }
 

crates/editor/src/editor_tests.rs

@@ -4999,6 +4999,57 @@ async fn test_toggle_comment(cx: &mut gpui::TestAppContext) {
             "
             .unindent()
         );
+
+        // If a selection span a single line and is empty, the line is toggled.
+        editor.set_text(
+            "
+
+            fn a() { }
+
+            "
+            .unindent(),
+            cx,
+        );
+        editor.change_selections(None, cx, |s| {
+            s.select_display_ranges([
+                DisplayPoint::new(0, 0)..DisplayPoint::new(0, 0),
+                DisplayPoint::new(2, 0)..DisplayPoint::new(2, 0),
+            ])
+        });
+        editor.toggle_comments(&ToggleComments::default(), cx);
+        assert_eq!(
+            editor.text(cx),
+            "
+                //\x20
+                fn a() { }
+                //\x20
+            "
+            .unindent()
+        );
+
+        // If a selection span multiple lines, empty lines are not toggled.
+        editor.set_text(
+            "
+
+            fn a() { }
+
+            "
+            .unindent(),
+            cx,
+        );
+        editor.change_selections(None, cx, |s| {
+            s.select_display_ranges([DisplayPoint::new(0, 0)..DisplayPoint::new(2, 0)])
+        });
+        editor.toggle_comments(&ToggleComments::default(), cx);
+        assert_eq!(
+            editor.text(cx),
+            "
+
+                // fn a() { }
+
+            "
+            .unindent()
+        );
     });
 }