Enable `clippy::non_canonical_clone_impl` (#9373)

Marshall Bowers created

This PR enables the
[`clippy::non_canonical_clone_impl`](https://rust-lang.github.io/rust-clippy/master/index.html#/non_canonical_clone_impl)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

Cargo.toml             | 1 -
crates/rpc/src/peer.rs | 6 +-----
2 files changed, 1 insertion(+), 6 deletions(-)

Detailed changes

Cargo.toml 🔗

@@ -415,7 +415,6 @@ arc_with_non_send_sync = "allow"
 borrowed_box = "allow"
 let_underscore_future = "allow"
 map_entry = "allow"
-non_canonical_clone_impl = "allow"
 non_canonical_partial_ord_impl = "allow"
 reversed_empty_ranges = "allow"
 type_complexity = "allow"

crates/rpc/src/peer.rs 🔗

@@ -63,11 +63,7 @@ pub struct Receipt<T> {
 
 impl<T> Clone for Receipt<T> {
     fn clone(&self) -> Self {
-        Self {
-            sender_id: self.sender_id,
-            message_id: self.message_id,
-            payload_type: PhantomData,
-        }
+        *self
     }
 }