From ab089b65754ae3ea1cd1a73d9f17d5ea56d121f8 Mon Sep 17 00:00:00 2001 From: Antonio Scandurra Date: Wed, 30 Jun 2021 12:05:58 +0200 Subject: [PATCH] Avoid logging errors in RPC message handlers The `on_message` helper already logs when an error occurs. --- zed/src/worktree.rs | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/zed/src/worktree.rs b/zed/src/worktree.rs index 5911480404fd11677ef4c35b0b6ba488f1c4891e..cd13a83da3882cd82136c56c68ca7de6566a4f0a 100644 --- a/zed/src/worktree.rs +++ b/zed/src/worktree.rs @@ -2002,16 +2002,8 @@ mod remote { ) -> anyhow::Result<()> { let message = envelope.payload; let mut state = rpc.state.lock().await; - match state.shared_worktree(message.worktree_id, cx) { - Ok(worktree) => { - if let Err(error) = worktree.update(cx, |tree, cx| tree.update_buffer(message, cx)) - { - log::error!("error applying operations to buffer: {}", error); - } - } - Err(error) => log::error!("{}", error), - } - + let worktree = state.shared_worktree(message.worktree_id, cx)?; + worktree.update(cx, |tree, cx| tree.update_buffer(message, cx))?; Ok(()) } }