More

Conrad Irwin created 14 hours ago

Change summary

.github/workflows/compare_perf.yml                | 10 ++++++----
tooling/xtask/src/tasks/workflows/compare_perf.rs |  3 ++-
2 files changed, 8 insertions(+), 5 deletions(-)

Detailed changes

.github/workflows/compare_perf.yml

@@ -23,13 +23,15 @@ jobs:
     - name: compare_perf::run_perf::echo_inputs
       run: echo ${{ inputs.base }} ${{ inputs.head }}
       shell: bash -euxo pipefail {0}
-    - name: git checkout ${{ inputs.base }}
-      run: git checkout ${{ inputs.base }}
+    - name: compare_perf::run_perf::git_checkout
+      run: git fetch origin ${{ inputs.base }} && git checkout ${{ inputs.base }}
+      shell: bash -euxo pipefail {0}
     - name: compare_perf::run_perf::cargo_perf_test
       run: cargo perf-test -p gpui -- --json=${{ inputs.base }}
       shell: bash -euxo pipefail {0}
-    - name: git checkout ${{ inputs.head }}
-      run: git checkout ${{ inputs.head }}
+    - name: compare_perf::run_perf::git_checkout
+      run: git fetch origin ${{ inputs.head }} && git checkout ${{ inputs.head }}
+      shell: bash -euxo pipefail {0}
     - name: compare_perf::run_perf::cargo_perf_test
       run: cargo perf-test -p gpui -- --json=${{ inputs.head }}
       shell: bash -euxo pipefail {0}

tooling/xtask/src/tasks/workflows/compare_perf.rs

@@ -30,7 +30,8 @@ pub fn run_perf(base: &Input, head: &Input) -> NamedJob {
     }
 
     fn git_checkout(ref_name: String) -> Step<Run> {
-        Step::new(&format!("git checkout {ref_name}")).run(&format!("git checkout {ref_name}"))
+        named::bash(
+            &format!("git fetch origin {ref_name} && git checkout {ref_name}"))
     }
 
     fn compare_runs(head: String, base: String) -> Step<Run> {