From ae414e21f029a841989ccfb228f003691311e257 Mon Sep 17 00:00:00 2001 From: Jason Lee Date: Wed, 10 Jul 2024 03:04:55 +0800 Subject: [PATCH] gpui: Fix hide titlebar on Windows, with `titlebar: None` option (#13975) Release Notes: - N/A Ref the macOS Window: When the `titlebar` is none, the titlebar should be hidden. https://github.com/zed-industries/zed/blob/adaa4831766cde63b408909cf65cdeb1641e5888/crates/gpui/src/platform/mac/window.rs#L516-L528 ``` cargo run -p gpui --example window_positioning ``` ## Before ![img_v3_02ck_939c23d0-acc6-40c1-aaf7-c6dd73ddf7ag](https://github.com/zed-industries/zed/assets/5518/f2c7aa02-a102-4f24-8243-74219957d16b) ## After image --- crates/gpui/src/platform/windows/window.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/gpui/src/platform/windows/window.rs b/crates/gpui/src/platform/windows/window.rs index 46a2a4e6b3b4ea22bd2556e47973759e4e023a9b..e4c668463cafd006f1af69be475c54d3cea9c045 100644 --- a/crates/gpui/src/platform/windows/window.rs +++ b/crates/gpui/src/platform/windows/window.rs @@ -252,7 +252,7 @@ impl WindowsWindow { .titlebar .as_ref() .map(|titlebar| titlebar.appears_transparent) - .unwrap_or(false); + .unwrap_or(true); let windowname = HSTRING::from( params .titlebar