From aea6fa0c09828e74986cad67882f7726b704246b Mon Sep 17 00:00:00 2001
From: moshyfawn <email@moshyfawn.dev>
Date: Fri, 29 Nov 2024 15:37:24 -0500
Subject: [PATCH] Remove project panel trash action for remote projects
 (#21300)

Closes #20845

I'm uncertain about my placement for the logic to remove actions from
the command palette list. If anyone has insights or alternative
approaches, I'm open to changing the code.

Release Notes:

- Removed project panel `Trash` action for remote projects.

---------

Co-authored-by: Finn Evers <dev@bahn.sh>
---
 Cargo.lock                                |  1 +
 crates/project_panel/Cargo.toml           |  1 +
 crates/project_panel/src/project_panel.rs | 17 +++++++++++++++--
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index bdb839e78b38c132b64f1674d2d92493ee060f06..7768dac710feff6960f8e0723a004fa1db09fbdb 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -9313,6 +9313,7 @@ dependencies = [
  "anyhow",
  "client",
  "collections",
+ "command_palette_hooks",
  "db",
  "editor",
  "file_icons",
diff --git a/crates/project_panel/Cargo.toml b/crates/project_panel/Cargo.toml
index dbcabc9f83e707c0109478e70aa5e9f32fc265b5..af913d9d6b472862d48282f30126eaa56007ab14 100644
--- a/crates/project_panel/Cargo.toml
+++ b/crates/project_panel/Cargo.toml
@@ -15,6 +15,7 @@ doctest = false
 [dependencies]
 anyhow.workspace = true
 collections.workspace = true
+command_palette_hooks.workspace = true
 db.workspace = true
 editor.workspace = true
 file_icons.workspace = true
diff --git a/crates/project_panel/src/project_panel.rs b/crates/project_panel/src/project_panel.rs
index 98037429661725bf977456c6f091f0fef9fec260..bfb07fc7fd13022e076e122f636e07b884779a23 100644
--- a/crates/project_panel/src/project_panel.rs
+++ b/crates/project_panel/src/project_panel.rs
@@ -17,6 +17,7 @@ use file_icons::FileIcons;
 
 use anyhow::{anyhow, Context as _, Result};
 use collections::{hash_map, BTreeSet, HashMap};
+use command_palette_hooks::CommandPaletteFilter;
 use git::repository::GitFileStatus;
 use gpui::{
     actions, anchored, deferred, div, impl_actions, point, px, size, uniform_list, Action,
@@ -38,6 +39,7 @@ use project_panel_settings::{
 };
 use serde::{Deserialize, Serialize};
 use smallvec::SmallVec;
+use std::any::TypeId;
 use std::{
     cell::OnceCell,
     cmp,
@@ -311,6 +313,15 @@ impl ProjectPanel {
             })
             .detach();
 
+            let trash_action = [TypeId::of::<Trash>()];
+            let is_remote = project.read(cx).is_via_collab();
+
+            if is_remote {
+                CommandPaletteFilter::update_global(cx, |filter, _cx| {
+                    filter.hide_action_types(&trash_action);
+                });
+            }
+
             let filename_editor = cx.new_view(Editor::single_line);
 
             cx.subscribe(
@@ -655,9 +666,11 @@ impl ProjectPanel {
                             .action("Copy Relative Path", Box::new(CopyRelativePath))
                             .separator()
                             .action("Rename", Box::new(Rename))
-                            .when(!is_root, |menu| {
+                            .when(!is_root & !is_remote, |menu| {
                                 menu.action("Trash", Box::new(Trash { skip_prompt: false }))
-                                    .action("Delete", Box::new(Delete { skip_prompt: false }))
+                            })
+                            .when(!is_root, |menu| {
+                                menu.action("Delete", Box::new(Delete { skip_prompt: false }))
                             })
                             .when(!is_remote & is_root, |menu| {
                                 menu.separator()