From af2bb55fcdded3b0ae1bd3193688bec7ae8877d4 Mon Sep 17 00:00:00 2001 From: Nate Butler Date: Tue, 5 Sep 2023 10:49:38 -0400 Subject: [PATCH] Fix cropped search filters (#2932) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Because of the way we set up tools that add rows inside the toolbar it is complicated to tighten up the spacing inside the toolbar. This PR just reverts the changes I made previously. We'll need to properly add rows below the toolbar instead of rendering search inside of it to have non-equal height tools be able to descend from it. Release Notes: - Preview – Fixed an issue where search filters were partially cut off in the UI. --- styles/src/style_tree/search.ts | 4 ++-- styles/src/style_tree/toolbar.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/styles/src/style_tree/search.ts b/styles/src/style_tree/search.ts index a93aab4ea86ea660d4c33802abdc466e3ad76c7a..8174690fde913787845912defe44616d0a49ac21 100644 --- a/styles/src/style_tree/search.ts +++ b/styles/src/style_tree/search.ts @@ -48,7 +48,7 @@ export default function search(): any { } return { - padding: { top: 0, bottom: 0 }, + padding: { top: 4, bottom: 4 }, option_button: toggleable({ base: interactive({ @@ -394,7 +394,7 @@ export default function search(): any { }), }, }), - search_bar_row_height: 32, + search_bar_row_height: 34, search_row_spacing: 8, option_button_height: 22, modes_container: {}, diff --git a/styles/src/style_tree/toolbar.ts b/styles/src/style_tree/toolbar.ts index 7292a220a838ae441e6520e806408f6b3ad69d59..2d96293e309e059de14f29a9fb58ffb555020fff 100644 --- a/styles/src/style_tree/toolbar.ts +++ b/styles/src/style_tree/toolbar.ts @@ -7,8 +7,8 @@ export const toolbar = () => { const theme = useTheme() return { - height: 32, - padding: { left: 4, right: 4, top: 4, bottom: 4 }, + height: 42, + padding: { left: 4, right: 4 }, background: background(theme.highest), border: border(theme.highest, { bottom: true }), item_spacing: 4,