From afb208cfd8bdaa15ee8c71c6e0390dea00f00f19 Mon Sep 17 00:00:00 2001
From: Ben Kunkle <ben@zed.dev>
Date: Fri, 15 Aug 2025 16:59:57 -0500
Subject: [PATCH] keymap_ui: Don't try to parse empty action arguments as JSON
 (#36278)

Closes #ISSUE

Release Notes:

- Keymap Editor: Fixed an issue where leaving the arguments field empty
would result in an error even if arguments were optional
---
 crates/settings_ui/src/keybindings.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crates/settings_ui/src/keybindings.rs b/crates/settings_ui/src/keybindings.rs
index 81c461fed6e99a85681d59eb5860223ec2b46a1d..5a996a162e3382b07074cf92935d5b9143ed200c 100644
--- a/crates/settings_ui/src/keybindings.rs
+++ b/crates/settings_ui/src/keybindings.rs
@@ -2152,6 +2152,7 @@ impl KeybindingEditorModal {
 
         let value = action_arguments
             .as_ref()
+            .filter(|args| !args.is_empty())
             .map(|args| {
                 serde_json::from_str(args).context("Failed to parse action arguments as JSON")
             })