Ensure there's always at least one selection in the editor

Antonio Scandurra and Nathan Sobo created 4 years ago

Co-Authored-By: Nathan Sobo <[e-mail]>

Change summary

crates/editor/src/editor.rs | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)

Detailed changes

crates/editor/src/editor.rs

@@ -1224,6 +1224,7 @@ impl Editor {
             goal: SelectionGoal::None,
         };
 
+        self.pending_selection = Some(PendingSelection { selection, mode });
         if !add {
             self.update_selections::<usize>(Vec::new(), None, cx);
         } else if click_count > 1 {
@@ -1233,8 +1234,6 @@ impl Editor {
             self.update_selections::<usize>(selections, None, cx)
         }
 
-        self.pending_selection = Some(PendingSelection { selection, mode });
-
         cx.notify();
     }
 
@@ -4359,19 +4358,16 @@ impl Editor {
             .display_map
             .update(cx, |display_map, cx| display_map.snapshot(cx));
         let buffer = &display_map.buffer_snapshot;
-        self.pending_selection = None;
+        if !self.selections.is_empty() {
+            self.pending_selection = None;
+        }
         self.add_selections_state = None;
         self.select_next_state = None;
         self.select_larger_syntax_node_stack.clear();
         self.autoclose_stack.invalidate(&self.selections, &buffer);
         self.snippet_stack.invalidate(&self.selections, &buffer);
 
-        let new_cursor_position = self
-            .selections
-            .iter()
-            .max_by_key(|s| s.id)
-            .map(|s| s.head())
-            .unwrap();
+        let new_cursor_position = self.newest_anchor_selection().head();
 
         self.push_to_nav_history(
             old_cursor_position.clone(),