From b1af02ca710094452521965d02b1eb051c1911b9 Mon Sep 17 00:00:00 2001
From: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Date: Tue, 2 Dec 2025 17:38:18 -0300
Subject: [PATCH] debugger: Improve step icons (#44017)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Closes https://github.com/zed-industries/zed/issues/38475
Release Notes:
- N/A
---
assets/icons/debug_step_back.svg | 1 -
assets/icons/debug_step_into.svg | 6 ++-
assets/icons/debug_step_out.svg | 6 ++-
assets/icons/debug_step_over.svg | 6 ++-
crates/debugger_ui/src/debugger_panel.rs | 47 +++++++++++-------------
crates/icons/src/icons.rs | 1 -
6 files changed, 37 insertions(+), 30 deletions(-)
delete mode 100644 assets/icons/debug_step_back.svg
diff --git a/assets/icons/debug_step_back.svg b/assets/icons/debug_step_back.svg
deleted file mode 100644
index 61d45866f61cbabbd9a7ae9975809d342cb76ed5..0000000000000000000000000000000000000000
--- a/assets/icons/debug_step_back.svg
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/assets/icons/debug_step_into.svg b/assets/icons/debug_step_into.svg
index 9a517fc7ca0762b17446a75cd90f39a91e1b51cf..0a5882354380b659425fecca2b4c6000516e422f 100644
--- a/assets/icons/debug_step_into.svg
+++ b/assets/icons/debug_step_into.svg
@@ -1 +1,5 @@
-
+
diff --git a/assets/icons/debug_step_out.svg b/assets/icons/debug_step_out.svg
index 147a44f930f34f6c3ddce94693a178a932129cb5..c128f56111f2b68d7229f9d2f61b6b2496f99bba 100644
--- a/assets/icons/debug_step_out.svg
+++ b/assets/icons/debug_step_out.svg
@@ -1 +1,5 @@
-
+
diff --git a/assets/icons/debug_step_over.svg b/assets/icons/debug_step_over.svg
index 336abc11deb866a128e8418dab47af01b6e4d3f6..5d8ccd5b7a20b2f8a108ab4c2e03694db4f6f8a8 100644
--- a/assets/icons/debug_step_over.svg
+++ b/assets/icons/debug_step_over.svg
@@ -1 +1,5 @@
-
+
diff --git a/crates/debugger_ui/src/debugger_panel.rs b/crates/debugger_ui/src/debugger_panel.rs
index 3890fa6326329d0d72aa6f81c6b94e7c2f364d34..ffdd4a22e3d092eb5d3d6626dcfe8b167ae03936 100644
--- a/crates/debugger_ui/src/debugger_panel.rs
+++ b/crates/debugger_ui/src/debugger_panel.rs
@@ -740,7 +740,7 @@ impl DebugPanel {
}
})
.child(
- IconButton::new("debug-step-over", IconName::ArrowRight)
+ IconButton::new("step-over", IconName::DebugStepOver)
.icon_size(IconSize::Small)
.on_click(window.listener_for(
running_state,
@@ -762,32 +762,29 @@ impl DebugPanel {
}),
)
.child(
- IconButton::new(
- "debug-step-into",
- IconName::ArrowDownRight,
- )
- .icon_size(IconSize::Small)
- .on_click(window.listener_for(
- running_state,
- |this, _, _window, cx| {
- this.step_in(cx);
- },
- ))
- .disabled(thread_status != ThreadStatus::Stopped)
- .tooltip({
- let focus_handle = focus_handle.clone();
- move |_window, cx| {
- Tooltip::for_action_in(
- "Step In",
- &StepInto,
- &focus_handle,
- cx,
- )
- }
- }),
+ IconButton::new("step-into", IconName::DebugStepInto)
+ .icon_size(IconSize::Small)
+ .on_click(window.listener_for(
+ running_state,
+ |this, _, _window, cx| {
+ this.step_in(cx);
+ },
+ ))
+ .disabled(thread_status != ThreadStatus::Stopped)
+ .tooltip({
+ let focus_handle = focus_handle.clone();
+ move |_window, cx| {
+ Tooltip::for_action_in(
+ "Step In",
+ &StepInto,
+ &focus_handle,
+ cx,
+ )
+ }
+ }),
)
.child(
- IconButton::new("debug-step-out", IconName::ArrowUpRight)
+ IconButton::new("step-out", IconName::DebugStepOut)
.icon_size(IconSize::Small)
.on_click(window.listener_for(
running_state,
diff --git a/crates/icons/src/icons.rs b/crates/icons/src/icons.rs
index da3b298751d9c1921d14722490e3cbc680292099..d28e2c1030c3c2378aa7997f4799c503cee97105 100644
--- a/crates/icons/src/icons.rs
+++ b/crates/icons/src/icons.rs
@@ -86,7 +86,6 @@ pub enum IconName {
DebugIgnoreBreakpoints,
DebugLogBreakpoint,
DebugPause,
- DebugStepBack,
DebugStepInto,
DebugStepOut,
DebugStepOver,