From b204582f7e901d140961ac2eb0d6c2fdb7a30043 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Soares?= <37777652+Dnreikronos@users.noreply.github.com> Date: Mon, 20 Apr 2026 10:28:45 -0300 Subject: [PATCH] Add NewFile keybinding to Welcome context (#52463) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Context `ctrl-n` / `cmd-n` doesn't work on the Welcome tab. The global binding lives under `Workspace && !Terminal` (macOS) and similar contexts that don't include Welcome. The fix just adds the same binding to the Welcome context block on all three platforms — same approach the font-size and recent-project shortcuts already use there. Closes #52426 ## Demo ### Before: https://github.com/user-attachments/assets/69becde8-25d2-45e3-9e7c-416b7937bd17 ### After: https://github.com/user-attachments/assets/6d9ede76-7adb-4527-bfef-c18d5b8a4fb4 ## How to review One line added per platform keymap file. Check that `ctrl-n` / `cmd-n` maps to `workspace::NewFile` in the `Welcome` block of: - `assets/keymaps/default-macos.json` - `assets/keymaps/default-linux.json` - `assets/keymaps/default-windows.json` ## Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed `ctrl-n` / `cmd-n` (New File) not working on the Welcome tab Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> --- assets/keymaps/default-linux.json | 1 + assets/keymaps/default-macos.json | 1 + assets/keymaps/default-windows.json | 1 + 3 files changed, 3 insertions(+) diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json index 959a76e7fcc506ab55872b4cda99f83c435c462f..2f0f823cd399f95f8517e784e197af8d7f657f17 100644 --- a/assets/keymaps/default-linux.json +++ b/assets/keymaps/default-linux.json @@ -1368,6 +1368,7 @@ "context": "Welcome", "use_key_equivalents": true, "bindings": { + "ctrl-n": "workspace::NewFile", "ctrl-=": ["zed::IncreaseUiFontSize", { "persist": false }], "ctrl-+": ["zed::IncreaseUiFontSize", { "persist": false }], "ctrl--": ["zed::DecreaseUiFontSize", { "persist": false }], diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json index be26f29d244dc2693b73dd5f6d411a600efde5c1..ef31773bc11b3c6c5a4c0ce1d8afc16c552a5da9 100644 --- a/assets/keymaps/default-macos.json +++ b/assets/keymaps/default-macos.json @@ -1458,6 +1458,7 @@ "context": "Welcome", "use_key_equivalents": true, "bindings": { + "cmd-n": "workspace::NewFile", "cmd-=": ["zed::IncreaseUiFontSize", { "persist": false }], "cmd-+": ["zed::IncreaseUiFontSize", { "persist": false }], "cmd--": ["zed::DecreaseUiFontSize", { "persist": false }], diff --git a/assets/keymaps/default-windows.json b/assets/keymaps/default-windows.json index e87625c1d87d824ccb52ed38627b28939d876fbb..d576a6a5169affce5a335a22bdf9265f9a7490f3 100644 --- a/assets/keymaps/default-windows.json +++ b/assets/keymaps/default-windows.json @@ -1390,6 +1390,7 @@ "context": "Welcome", "use_key_equivalents": true, "bindings": { + "ctrl-n": "workspace::NewFile", "ctrl-=": ["zed::IncreaseUiFontSize", { "persist": false }], "ctrl-+": ["zed::IncreaseUiFontSize", { "persist": false }], "ctrl--": ["zed::DecreaseUiFontSize", { "persist": false }],