From b3483a157cb4ecd77fc0343bdf57cf93e7852adb Mon Sep 17 00:00:00 2001 From: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com> Date: Mon, 27 Oct 2025 17:30:34 -0400 Subject: [PATCH] settings_ui: Fix tabbing in settings UI main page content (#41209) Tabbing into the main page would move focus to the navigation panel instead of auto-scrolling. This PR fixes that bug. Release Notes: - N/A --- crates/settings_ui/src/settings_ui.rs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/settings_ui/src/settings_ui.rs b/crates/settings_ui/src/settings_ui.rs index f7f5a975b78d6de3fd3a696d9e223baf7807071c..e60304a9f7bb34b6b802b59f4410c27f322cad01 100644 --- a/crates/settings_ui/src/settings_ui.rs +++ b/crates/settings_ui/src/settings_ui.rs @@ -2775,8 +2775,11 @@ impl SettingsWindow { this.list_state.scroll_to_reveal_item(next_logical_index); // We need to render the next item to ensure it's focus handle is in the element tree cx.on_next_frame(window, |_, window, cx| { - window.focus_next(); cx.notify(); + cx.on_next_frame(window, |_, window, cx| { + window.focus_next(); + cx.notify(); + }); }); cx.notify(); return; @@ -2804,8 +2807,11 @@ impl SettingsWindow { this.list_state.scroll_to_reveal_item(next_logical_index); // We need to render the next item to ensure it's focus handle is in the element tree cx.on_next_frame(window, |_, window, cx| { - window.focus_prev(); cx.notify(); + cx.on_next_frame(window, |_, window, cx| { + window.focus_prev(); + cx.notify(); + }); }); cx.notify(); return;