From b58bf64f0addca08b7b932722fb57caf54fcd84f Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Thu, 2 May 2024 16:36:45 -0700 Subject: [PATCH] Increase rate limits for computing embeddings (#11326) - Also, remove the rate limit for getting cached embeddings entirely. Release Notes: - N/A --- crates/collab/src/rpc.rs | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/crates/collab/src/rpc.rs b/crates/collab/src/rpc.rs index 6c82309eb018fe6fa0a8451f7f2f60a4bab66ecb..e4a83a43382bb8180be8b98f6e74ebcf501eee98 100644 --- a/crates/collab/src/rpc.rs +++ b/crates/collab/src/rpc.rs @@ -4501,7 +4501,7 @@ impl RateLimit for ComputeEmbeddingsRateLimit { std::env::var("EMBED_TEXTS_RATE_LIMIT_PER_HOUR") .ok() .and_then(|v| v.parse().ok()) - .unwrap_or(120) // Picked arbitrarily + .unwrap_or(5000) // Picked arbitrarily } fn refill_duration() -> chrono::Duration { @@ -4573,25 +4573,6 @@ async fn compute_embeddings( Ok(()) } -struct GetCachedEmbeddingsRateLimit; - -impl RateLimit for GetCachedEmbeddingsRateLimit { - fn capacity() -> usize { - std::env::var("EMBED_TEXTS_RATE_LIMIT_PER_HOUR") - .ok() - .and_then(|v| v.parse().ok()) - .unwrap_or(120) // Picked arbitrarily - } - - fn refill_duration() -> chrono::Duration { - chrono::Duration::hours(1) - } - - fn db_name() -> &'static str { - "get-cached-embeddings" - } -} - async fn get_cached_embeddings( request: proto::GetCachedEmbeddings, response: Response, @@ -4599,11 +4580,6 @@ async fn get_cached_embeddings( ) -> Result<()> { authorize_access_to_language_models(&session).await?; - session - .rate_limiter - .check::(session.user_id()) - .await?; - let db = session.db().await; let embeddings = db.get_embeddings(&request.model, &request.digests).await?;