From b7784d414a76165358e906b24dbce9d399669231 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Sat, 2 Mar 2024 02:03:30 +0200 Subject: [PATCH] When clicking the checkbox, toggle open the LSP trace logs (#8689) Before this change, enabling LSP trace checkbox closed the panel and toggled the server logs on. Now, the newly enabled trace logs are shown instead. Release Notes: - Improved LSP logs checkbox behavior --- crates/language_tools/src/lsp_log.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/language_tools/src/lsp_log.rs b/crates/language_tools/src/lsp_log.rs index 8723183789cdb81ea24254511413891b0d84ef9d..d2bdd95d7dc3a013ce272c6885c27bff992e0142 100644 --- a/crates/language_tools/src/lsp_log.rs +++ b/crates/language_tools/src/lsp_log.rs @@ -823,7 +823,7 @@ impl Render for LspLogToolbarItemView { selection, Selection::Selected ); - view.toggle_logging_for_server( + view.toggle_rpc_logging_for_server( row.server_id, enabled, cx, @@ -887,7 +887,7 @@ impl LspLogToolbarItemView { } } - fn toggle_logging_for_server( + fn toggle_rpc_logging_for_server( &mut self, id: LanguageServerId, enabled: bool, @@ -899,6 +899,9 @@ impl LspLogToolbarItemView { if !enabled && Some(id) == log_view.current_server_id { log_view.show_logs_for_server(id, cx); cx.notify(); + } else if enabled { + log_view.show_rpc_trace_for_server(id, cx); + cx.notify(); } cx.focus(&log_view.focus_handle); });