From b7c64e56b1f95cf787c0e52bd5e39f247cfb9125 Mon Sep 17 00:00:00 2001 From: Kunall Banerjee Date: Thu, 26 Mar 2026 07:44:05 -0400 Subject: [PATCH] settings_content: Fix hover descriptions for newtype wrapper settings (#51705) Happened to notice it when debugging some stuff. I initially only caught `git_hosting_providers`, but AI found another instance. | `disable_ai` | `git_hosting_providers` | |--------|--------| | image | image | Release Notes: - Fixed an issue where some settings used the wrong documentation in LSP hover documentation --- .../settings_content/src/settings_content.rs | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/crates/settings_content/src/settings_content.rs b/crates/settings_content/src/settings_content.rs index ea505cd2dcbd20bf5520169b808bb6848119a95a..861b6fee454edc4d18b8248b42315287a33c572c 100644 --- a/crates/settings_content/src/settings_content.rs +++ b/crates/settings_content/src/settings_content.rs @@ -1133,15 +1133,15 @@ pub struct WhichKeySettingsContent { pub delay_ms: Option, } +// An ExtendingVec in the settings can only accumulate new values. +// +// This is useful for things like private files where you only want +// to allow new values to be added. +// +// Consider using a HashMap instead of this type +// (like auto_install_extensions) so that user settings files can both add +// and remove values from the set. #[derive(Default, Debug, Clone, PartialEq, Serialize, Deserialize, JsonSchema)] -/// An ExtendingVec in the settings can only accumulate new values. -/// -/// This is useful for things like private files where you only want -/// to allow new values to be added. -/// -/// Consider using a HashMap instead of this type -/// (like auto_install_extensions) so that user settings files can both add -/// and remove values from the set. pub struct ExtendingVec(pub Vec); impl Into> for ExtendingVec { @@ -1161,10 +1161,10 @@ impl merge_from::MergeFrom for ExtendingVec { } } -/// A SaturatingBool in the settings can only ever be set to true, -/// later attempts to set it to false will be ignored. -/// -/// Used by `disable_ai`. +// A SaturatingBool in the settings can only ever be set to true, +// later attempts to set it to false will be ignored. +// +// Used by `disable_ai`. #[derive(Debug, Default, Copy, Clone, PartialEq, Serialize, Deserialize, JsonSchema)] pub struct SaturatingBool(pub bool);