From bb01d30923eb041f928e197be11ba62a13e6faba Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Tue, 17 Dec 2024 22:17:08 -0700 Subject: [PATCH] Fix panic in linked editing ranges (#21905) We were committing the cardinal sin of subtracting one from a column without clipping Closes #ISSUE Release Notes: - Fixed a panic in linked editing ranges --- crates/editor/src/editor.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 6039092be50ed0977fb3fe6618201f21033ae15c..d4f47330a4ccadf753e5721a569ecc7b855b8d1f 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -5271,7 +5271,8 @@ impl Editor { if end_point == start_point { let offset = text::ToOffset::to_offset(&range.start, &snapshot) .saturating_sub(1); - start_point = TP::to_point(&offset, &snapshot); + start_point = + snapshot.clip_point(TP::to_point(&offset, &snapshot), Bias::Left); }; (start_point..end_point, empty_str.clone())