Enable `clippy::unnecessary_to_owned` (#8908)

Kirpal Grewal created 2 years ago

lint for `unnecessary_to_owned` and fix the sole violation in the
codebase

Change summary

Cargo.toml                  | 1 -
crates/editor/src/editor.rs | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)

Detailed changes

Cargo.toml

@@ -384,7 +384,6 @@ reversed_empty_ranges = "allow"
 single_range_in_vec_init = "allow"
 suspicious_to_owned = "allow"
 type_complexity = "allow"
-unnecessary_to_owned = "allow"
 
 [workspace.metadata.cargo-machete]
 ignored = ["bindgen", "cbindgen", "prost_build", "serde"]

crates/editor/src/editor.rs

@@ -8720,7 +8720,7 @@ impl Editor {
 
         match permalink {
             Ok(permalink) => {
-                cx.open_url(&permalink.to_string());
+                cx.open_url(permalink.as_ref());
             }
             Err(err) => {
                 let message = format!("Failed to open permalink: {err}");