Enable `clippy::drain_collect` (#8745)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::drain_collect`](https://rust-lang.github.io/rust-clippy/master/index.html#/drain_collect)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/editor/src/element.rs | 2 +-
tooling/xtask/src/main.rs    | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

Detailed changes

crates/editor/src/element.rs

@@ -2883,7 +2883,7 @@ impl LineWithInvisibles {
                         .unwrap();
                     layouts.push(Self {
                         line: shaped_line,
-                        invisibles: invisibles.drain(..).collect(),
+                        invisibles: std::mem::take(&mut invisibles),
                     });
 
                     line.clear();

tooling/xtask/src/main.rs

@@ -89,7 +89,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::default_constructed_unit_structs",
         "clippy::derivable_impls",
         "clippy::derive_ord_xor_partial_ord",
-        "clippy::drain_collect",
         "clippy::eq_op",
         "clippy::expect_fun_call",
         "clippy::explicit_auto_deref",