Add reminder for the future

Joseph T. Lyons created 2 years ago

Change summary

crates/client/src/telemetry.rs                 | 2 +-
crates/client/src/telemetry/event_coalescer.rs | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)

Detailed changes

crates/client/src/telemetry.rs

@@ -204,7 +204,7 @@ impl Telemetry {
     #[cfg(not(any(test, feature = "test-support")))]
     fn shutdown_telemetry(self: &Arc<Self>) -> impl Future<Output = ()> {
         self.report_app_event("close");
-        self.flush_events();
+        // TODO: close final edit period and make sure it's sent
         Task::ready(())
     }
 

crates/client/src/telemetry/event_coalescer.rs

@@ -26,6 +26,10 @@ impl EventCoalescer {
         self.log_event_with_time(Utc::now(), environment)
     }
 
+    // pub fn close_current_period(&mut self) -> Option<(DateTime<Utc>, DateTime<Utc>)> {
+    //     self.environment.map(|env| self.log_event(env)).flatten()
+    // }
+
     fn log_event_with_time(
         &mut self,
         log_time: DateTime<Utc>,