From be21169a9531c5e0f9912744e217107df589c2e7 Mon Sep 17 00:00:00 2001 From: Mathias Date: Wed, 4 Sep 2024 08:58:16 +0200 Subject: [PATCH] vtsls: Enable Inlay Hints by default for JavaScript #17232 (#17334) Closes #17232 Release Notes: - Fixed inlay hints not being enabled for JavaScript when using the `vtsls` language server. (They were enabled by default for TypeScript) --- crates/languages/src/vtsls.rs | 62 +++++++++++++++++------------------ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/crates/languages/src/vtsls.rs b/crates/languages/src/vtsls.rs index 074a42ebd90eeda28b4a57faeacc2a5c911055d8..887a8a4d5aa859df6755aed45053b31b0ffbdadf 100644 --- a/crates/languages/src/vtsls.rs +++ b/crates/languages/src/vtsls.rs @@ -221,40 +221,38 @@ impl LspAdapter for VtslsLspAdapter { adapter: &Arc, ) -> Result> { let tsdk_path = Self::tsdk_path(&adapter).await; - Ok(Some(json!({ - "typescript": { - "tsdk": tsdk_path, - "suggest": { - "completeFunctionCalls": true - }, - "inlayHints": { - "parameterNames": { - "enabled": "all", - "suppressWhenArgumentMatchesName": false, - }, - "parameterTypes": { - "enabled": true - }, - "variableTypes": { - "enabled": true, - "suppressWhenTypeMatchesName": false, - }, - "propertyDeclarationTypes": { - "enabled": true, - }, - "functionLikeReturnTypes": { - "enabled": true, - }, - "enumMemberValues": { - "enabled": true, - } - } + let config = serde_json::json!({ + "tsdk": tsdk_path, + "suggest": { + "completeFunctionCalls": true }, - "javascript": { - "suggest": { - "completeFunctionCalls": true + "inlayHints": { + "parameterNames": { + "enabled": "all", + "suppressWhenArgumentMatchesName": false + }, + "parameterTypes": { + "enabled": true + }, + "variableTypes": { + "enabled": true, + "suppressWhenTypeMatchesName": false + }, + "propertyDeclarationTypes": { + "enabled": true + }, + "functionLikeReturnTypes": { + "enabled": true + }, + "enumMemberValues": { + "enabled": true } - }, + } + }); + + Ok(Some(json!({ + "typescript": config, + "javascript": config, "vtsls": { "experimental": { "completion": {