From c220fb387d0b2bd846ae10e7060c786cfbfc7e54 Mon Sep 17 00:00:00 2001 From: Michael Sloan Date: Sat, 15 Mar 2025 13:10:54 -0600 Subject: [PATCH] Fix panic when providing 0 to ilog10 in line number length logic (#26844) Introduced in #24428 Release Notes: - N/A --- crates/editor/src/element.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/editor/src/element.rs b/crates/editor/src/element.rs index 3095f77862da6dbdc8a0c1e98439da953801597f..8d9a02a1fcb3dbef92d2fc89d2252435d3eaf87d 100644 --- a/crates/editor/src/element.rs +++ b/crates/editor/src/element.rs @@ -2151,17 +2151,17 @@ impl EditorElement { }; let editor = self.editor.clone(); - let max_row = self + let max_line_number = self .editor .read(cx) .buffer() .read(cx) .snapshot(cx) .widest_line_number(); - let is_wide = max_row > 999 + let is_wide = max_line_number > 999 && row_info .buffer_row - .is_some_and(|row| row.ilog10() == max_row.ilog10()); + .is_some_and(|row| (row + 1).ilog10() == max_line_number.ilog10()); let toggle = IconButton::new(("expand", ix), icon_name) .icon_color(Color::Custom(cx.theme().colors().editor_line_number))