chore: Move a bunch of foreground tasks into background (#35322)

Piotr Osiewicz created 3 months ago

Closes #ISSUE

Release Notes:

- N/A

Change summary

crates/lsp/src/lsp.rs            | 6 +++---
crates/project/src/lsp_store.rs  | 2 +-
crates/remote/src/ssh_session.rs | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)

Detailed changes

crates/lsp/src/lsp.rs

@@ -421,14 +421,14 @@ impl LanguageServer {
             .map(|stderr| {
                 let io_handlers = io_handlers.clone();
                 let stderr_captures = stderr_capture.clone();
-                cx.spawn(async move |_| {
+                cx.background_spawn(async move {
                     Self::handle_stderr(stderr, io_handlers, stderr_captures)
                         .log_err()
                         .await
                 })
             })
             .unwrap_or_else(|| Task::ready(None));
-        let input_task = cx.spawn(async move |_| {
+        let input_task = cx.background_spawn(async move {
             let (stdout, stderr) = futures::join!(stdout_input_task, stderr_input_task);
             stdout.or(stderr)
         });
@@ -846,7 +846,7 @@ impl LanguageServer {
         configuration: Arc<DidChangeConfigurationParams>,
         cx: &App,
     ) -> Task<Result<Arc<Self>>> {
-        cx.spawn(async move |_| {
+        cx.background_spawn(async move {
             let response = self
                 .request::<request::Initialize>(params)
                 .await

crates/project/src/lsp_store.rs

@@ -424,7 +424,7 @@ impl LocalLspStore {
         if settings.as_ref().is_some_and(|b| b.path.is_some()) {
             let settings = settings.unwrap();
 
-            return cx.spawn(async move |_| {
+            return cx.background_spawn(async move {
                 let mut env = delegate.shell_env().await;
                 env.extend(settings.env.unwrap_or_default());
 

crates/remote/src/ssh_session.rs

@@ -1742,7 +1742,7 @@ impl SshRemoteConnection {
             }
         });
 
-        cx.spawn(async move |_| {
+        cx.background_spawn(async move {
             let result = futures::select! {
                 result = stdin_task.fuse() => {
                     result.context("stdin")