From c4858f8ae6eee4a38e303c53884048ea1b5eec4c Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Thu, 23 Oct 2025 12:25:36 +0300 Subject: [PATCH] Revert "Round the scroll offset in editor to fix jumping text (#40401)" (#40982) This reverts commit 3da4cddce205d71dcad760c6af66a8985b16ffbe. The scrolling is ~30% less for the same gesture, and I'm not using anything lodpi: https://github.com/user-attachments/assets/b19521fc-9e29-4bfd-9660-dc1e4c8ae846 Release Notes: - N/A --- crates/editor/src/element.rs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/crates/editor/src/element.rs b/crates/editor/src/element.rs index 944715a0dfa3747bcece23a643a144f891687b53..d371f6a0339f148d0ae3b21ff918ae5155554735 100644 --- a/crates/editor/src/element.rs +++ b/crates/editor/src/element.rs @@ -7233,16 +7233,9 @@ impl EditorElement { * ScrollPixelOffset::from(max_glyph_advance) - ScrollPixelOffset::from(delta.x * scroll_sensitivity)) / ScrollPixelOffset::from(max_glyph_advance); - - let scale_factor = window.scale_factor(); - let y = (current_scroll_position.y - * ScrollPixelOffset::from(line_height) - * ScrollPixelOffset::from(scale_factor) + let y = (current_scroll_position.y * ScrollPixelOffset::from(line_height) - ScrollPixelOffset::from(delta.y * scroll_sensitivity)) - .round() - / ScrollPixelOffset::from(line_height) - / ScrollPixelOffset::from(scale_factor); - + / ScrollPixelOffset::from(line_height); let mut scroll_position = point(x, y).clamp(&point(0., 0.), &position_map.scroll_max); let forbid_vertical_scroll = editor.scroll_manager.forbid_vertical_scroll();