lsp: Don't log oneshot channel errors from notify (#29857)

Cole Miller created 7 months ago

This is kind of noisy and not very informative.

Release Notes:

- N/A

Change summary

crates/copilot/src/copilot.rs   |  6 +++---
crates/lsp/src/lsp.rs           | 12 ++++++------
crates/project/src/lsp_store.rs | 10 +++++-----
3 files changed, 14 insertions(+), 14 deletions(-)

Detailed changes

crates/copilot/src/copilot.rs

@@ -278,7 +278,7 @@ impl RegisteredBuffer {
                                         content_changes,
                                     },
                                 )
-                                .log_err();
+                                .ok();
                         }
                         let _ = done_tx.send((buffer.snapshot_version, buffer.snapshot.clone()));
                         Some(())
@@ -732,7 +732,7 @@ impl Copilot {
                                 },
                             },
                         )
-                        .log_err();
+                        .ok();
 
                     RegisteredBuffer {
                         uri,
@@ -827,7 +827,7 @@ impl Copilot {
                             text_document: lsp::TextDocumentIdentifier::new(buffer.uri),
                         },
                     )
-                    .log_err();
+                    .ok();
             }
         }
     }

crates/lsp/src/lsp.rs

@@ -1164,7 +1164,7 @@ impl LanguageServer {
                             id: NumberOrString::Number(id),
                         },
                     )
-                    .log_err();
+                    .ok();
                 }
             });
 
@@ -1234,7 +1234,7 @@ impl LanguageServer {
                     removed: vec![],
                 },
             };
-            self.notify::<DidChangeWorkspaceFolders>(&params).log_err();
+            self.notify::<DidChangeWorkspaceFolders>(&params).ok();
         }
     }
     /// Add new workspace folder to the list.
@@ -1264,7 +1264,7 @@ impl LanguageServer {
                     }],
                 },
             };
-            self.notify::<DidChangeWorkspaceFolders>(&params).log_err();
+            self.notify::<DidChangeWorkspaceFolders>(&params).ok();
         }
     }
     pub fn set_workspace_folders(&self, folders: BTreeSet<Url>) {
@@ -1293,7 +1293,7 @@ impl LanguageServer {
             let params = DidChangeWorkspaceFoldersParams {
                 event: WorkspaceFoldersChangeEvent { added, removed },
             };
-            self.notify::<DidChangeWorkspaceFolders>(&params).log_err();
+            self.notify::<DidChangeWorkspaceFolders>(&params).ok();
         }
     }
 
@@ -1311,14 +1311,14 @@ impl LanguageServer {
         self.notify::<notification::DidOpenTextDocument>(&DidOpenTextDocumentParams {
             text_document: TextDocumentItem::new(uri, language_id, version, initial_text),
         })
-        .log_err();
+        .ok();
     }
 
     pub fn unregister_buffer(&self, uri: Url) {
         self.notify::<notification::DidCloseTextDocument>(&DidCloseTextDocumentParams {
             text_document: TextDocumentIdentifier::new(uri),
         })
-        .log_err();
+        .ok();
     }
 }
 

crates/project/src/lsp_store.rs

@@ -6092,7 +6092,7 @@ impl LspStore {
                         content_changes,
                     },
                 )
-                .log_err();
+                .ok();
         }
 
         None
@@ -6125,7 +6125,7 @@ impl LspStore {
                             text,
                         },
                     )
-                    .log_err();
+                    .ok();
             }
         }
 
@@ -7472,7 +7472,7 @@ impl LspStore {
                                 new_uri: new_uri.clone(),
                             }],
                         })
-                        .log_err();
+                        .ok();
                 }
             }
             Some(())
@@ -7575,7 +7575,7 @@ impl LspStore {
                     .notify::<lsp::notification::DidChangeWatchedFiles>(
                         &lsp::DidChangeWatchedFilesParams { changes },
                     )
-                    .log_err();
+                    .ok();
             }
             Some(())
         });
@@ -9140,7 +9140,7 @@ impl LspStore {
                     if !params.changes.is_empty() {
                         server
                             .notify::<lsp::notification::DidChangeWatchedFiles>(&params)
-                            .log_err();
+                            .ok();
                     }
                 }
             }